Conversation
zentron
commented
Feb 4, 2026
| var linkifiedAppName = instanceLinks != null | ||
| ? log.FormatLink(instanceLinks.ApplicationDetails(application.Name, application.KubernetesNamespace), application.Name) | ||
| : application.Name; | ||
| ? log.FormatLink(instanceLinks.ApplicationDetails(applicationName, application.KubernetesNamespace), applicationName) |
Contributor
Author
There was a problem hiding this comment.
This was just updated to be similar to the manifest convention. Im hoping to consolidate some of this shared logic later
flin-8
reviewed
Feb 4, 2026
source/Calamari/ArgoCD/Conventions/UpdateArgoCDAppImagesInstallConvention.cs
Outdated
Show resolved
Hide resolved
zentron
force-pushed
the
robe/refactor2
branch
from
abb98cb to
bad97c9
Compare
zentron
force-pushed
the
robe/refactor3
branch
from
04d51cc to
b6cb684
Compare
zentron
force-pushed
the
robe/refactor3
branch
from
49834fa to
37ae172
Compare
flin-8
reviewed
Feb 5, 2026
source/Calamari/ArgoCD/Conventions/UpdateArgoCDApplicationManifestsInstallConvention.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small shuffling of where and how we construct the response object to find the similarities and bring together their construction into one spot to make it easier to understand how/where they are used